docs: adopt the open-chat port friction log#157
Conversation
The friction log written during the open-chat Composer port lived as FRICTION.md on the port branch in prisma/open-chat — a repo that is not ours to fill with Composer process artifacts. It is Composer dogfooding output, so it moves here next to gotchas.md and dogfood-report.md, verbatim apart from a provenance note in the header. The port branch drops the file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a friction log for porting open-chat to prisma/composer. It records fourteen incidents across type and runtime contracts, packaging, local development, secrets, hot reload, deployment stages, optional dependencies, database migrations, preview package installation, and streaming routing keys. Each incident includes observed behavior, causes, workarounds or operator procedures, recommendations, and follow-up references. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FRICTION.md was Prisma Composer dogfooding process output, not part of the port itself — it does not belong in this repository. It now lives in prisma/composer as open-chat-port-friction.md (prisma/composer#157), verbatim. The three comments that pointed at it drop the pointer and keep their substance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
The port's "app code unchanged" constraint was dropped; open-chat now consumes the service node directly and the launcher/env-shim scaffolding is gone. One capability gap remains as finding #14: the hydrated StreamsClient has no routing-key support and no public accessor for its raw connection values, so an app multiplexing chats over one per-user stream must keep the configKey() reach-around. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@open-chat-port-friction.md`:
- Line 91: Add the text language identifier to the fenced code blocks at the
referenced locations, including the stack trace and file listing, by changing
each opening fence to use text.
- Around line 231-233: Correct the alternative glob example in the documentation
by using matching delimiters around */dist/server/start.js, while preserving the
existing --external example and build:launcher reference.
- Around line 8-11: Update the header provenance note in
open-chat-port-friction.md to include D7 rather than stating it was appended
only through D6, and replace the outdated single D1 framework-version reference
with wording that framework versions are recorded per dispatch section.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e503c72b-f802-4424-8ed0-3c2d6f5e01d4
📒 Files selected for processing (1)
open-chat-port-friction.md
Credentials for an off-by-default feature (open-chat social sign-in)
cannot live on the service node: secrets() resolves every slot eagerly
and one unbound slot fails the whole call, so the four OAuth variables
stay plain process.env reads. Recommendation: secret({ optional: true })
resolving to undefined, with absent optional slots reported by the
deploy.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
Header provenance covers D1-D7 and points at per-dispatch version headers instead of the frozen D1 preview; the two bare fences get text language tags; the glob example gains its missing opening quote. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
@coderabbitai resolve |
Head branch was modified
✅ Action performedComments resolved and changes approved. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
The friction log from the open-chat Composer port (D1–D6: every workaround, missing capability, and illegible error the port surfaced, including the since-resolved #9 origin two-step and #12 by-hand schema step) lived as
FRICTION.mdon the port branch inprisma/open-chat. That repo is not ours — Composer process artifacts don't belong in it. The log is dogfooding output, so it moves here next togotchas.mdanddogfood-report.md, verbatim apart from a provenance note in the header. prisma/open-chat#1 drops the file in a matching commit.🤖 Generated with Claude Code