Skip to content

docs: adopt the open-chat port friction log#157

Merged
wmadden-electric merged 5 commits into
mainfrom
claude/open-chat-friction-log
Jul 23, 2026
Merged

docs: adopt the open-chat port friction log#157
wmadden-electric merged 5 commits into
mainfrom
claude/open-chat-friction-log

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

The friction log from the open-chat Composer port (D1–D6: every workaround, missing capability, and illegible error the port surfaced, including the since-resolved #9 origin two-step and #12 by-hand schema step) lived as FRICTION.md on the port branch in prisma/open-chat. That repo is not ours — Composer process artifacts don't belong in it. The log is dogfooding output, so it moves here next to gotchas.md and dogfood-report.md, verbatim apart from a provenance note in the header. prisma/open-chat#1 drops the file in a matching commit.

🤖 Generated with Claude Code

The friction log written during the open-chat Composer port lived as
FRICTION.md on the port branch in prisma/open-chat — a repo that is not
ours to fill with Composer process artifacts. It is Composer dogfooding
output, so it moves here next to gotchas.md and dogfood-report.md,
verbatim apart from a provenance note in the header. The port branch
drops the file.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@wmadden-electric, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 48a4d4fa-35ff-4a03-85c4-4ce978002608

📥 Commits

Reviewing files that changed from the base of the PR and between 61fa4db and bdc32d8.

📒 Files selected for processing (1)
  • open-chat-port-friction.md

Walkthrough

Adds a friction log for porting open-chat to prisma/composer. It records fourteen incidents across type and runtime contracts, packaging, local development, secrets, hot reload, deployment stages, optional dependencies, database migrations, preview package installation, and streaming routing keys. Each incident includes observed behavior, causes, workarounds or operator procedures, recommendations, and follow-up references.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adopting the open-chat port friction log into docs.
Description check ✅ Passed The description is directly about moving the open-chat friction log into this repository and matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/open-chat-friction-log
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/open-chat-friction-log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

wmadden-electric added a commit to prisma/open-chat that referenced this pull request Jul 22, 2026
FRICTION.md was Prisma Composer dogfooding process output, not part of
the port itself — it does not belong in this repository. It now lives in
prisma/composer as open-chat-port-friction.md (prisma/composer#157),
verbatim. The three comments that pointed at it drop the pointer and
keep their substance.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
The port's "app code unchanged" constraint was dropped; open-chat now
consumes the service node directly and the launcher/env-shim scaffolding
is gone. One capability gap remains as finding #14: the hydrated
StreamsClient has no routing-key support and no public accessor for its
raw connection values, so an app multiplexing chats over one per-user
stream must keep the configKey() reach-around.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@open-chat-port-friction.md`:
- Line 91: Add the text language identifier to the fenced code blocks at the
referenced locations, including the stack trace and file listing, by changing
each opening fence to use text.
- Around line 231-233: Correct the alternative glob example in the documentation
by using matching delimiters around */dist/server/start.js, while preserving the
existing --external example and build:launcher reference.
- Around line 8-11: Update the header provenance note in
open-chat-port-friction.md to include D7 rather than stating it was appended
only through D6, and replace the outdated single D1 framework-version reference
with wording that framework versions are recorded per dispatch section.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e503c72b-f802-4424-8ed0-3c2d6f5e01d4

📥 Commits

Reviewing files that changed from the base of the PR and between 46fa2c3 and 61fa4db.

📒 Files selected for processing (1)
  • open-chat-port-friction.md

Comment thread open-chat-port-friction.md Outdated
Comment thread open-chat-port-friction.md Outdated
Comment thread open-chat-port-friction.md
Credentials for an off-by-default feature (open-chat social sign-in)
cannot live on the service node: secrets() resolves every slot eagerly
and one unbound slot fails the whole call, so the four OAuth variables
stay plain process.env reads. Recommendation: secret({ optional: true })
resolving to undefined, with absent optional slots reported by the
deploy.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
Header provenance covers D1-D7 and points at per-dispatch version
headers instead of the frozen D1 preview; the two bare fences get text
language tags; the glob example gains its missing opening quote.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@wmadden-electric

Copy link
Copy Markdown
Contributor Author

@coderabbitai resolve

auto-merge was automatically disabled July 23, 2026 08:16

Head branch was modified

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
✅ Action performed

Comments resolved and changes approved.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@wmadden-electric
wmadden-electric merged commit 127f95c into main Jul 23, 2026
14 checks passed
@wmadden-electric
wmadden-electric deleted the claude/open-chat-friction-log branch July 23, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants