Skip to content

fix(release): bump-minor regenerates the lockfile#145

Merged
wmadden merged 1 commit into
mainfrom
chore/bump-minor-lockfile
Jul 24, 2026
Merged

fix(release): bump-minor regenerates the lockfile#145
wmadden merged 1 commit into
mainfrom
chore/bump-minor-lockfile

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

The v0.2.0 release PR (#143) failed every CI job at the install step: the bump rewrote the internal workspace:<version> pins in all 32 manifests, but pnpm-lock.yaml still recorded the old version, and CI installs with --frozen-lockfile.

This makes the release tooling regenerate the lockfile itself so the procedure can't miss it again:

  • scripts/bump-minor.ts now runs pnpm install --lockfile-only after stamping versions.
  • Adds the pnpm bump-minor script that both docs/oss/versioning.md and the publish-npm-version skill already referenced but which didn't exist.
  • The skill and versioning doc now state that the bump diff must include pnpm-lock.yaml and why.

Verified by running pnpm bump-minor on a clean checkout: the diff contains all 32 workspace package.json files plus pnpm-lock.yaml, and pnpm install --frozen-lockfile passes afterwards.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@wmadden, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8913b51b-8cd4-4cc3-af94-e013852b2fa2

📥 Commits

Reviewing files that changed from the base of the PR and between faffb25 and 2d126f2.

📒 Files selected for processing (4)
  • docs/oss/versioning.md
  • package.json
  • scripts/bump-minor.ts
  • skills-contrib/publish-npm-version/SKILL.md

Walkthrough

Added a bump-minor package script that runs the version bump utility. The utility now regenerates pnpm-lock.yaml with pnpm install --lockfile-only after updating workspace versions. Release documentation and publishing instructions now describe the lockfile update, --frozen-lockfile CI behavior, and the expected diff.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: bump-minor now regenerates the lockfile during release bumps.
Description check ✅ Passed The description matches the changeset and explains the lockfile regeneration, new script, and updated docs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-minor-lockfile
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/bump-minor-lockfile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@prisma/composer@145
npm i https://pkg.pr.new/@prisma/composer-prisma-cloud@145

commit: 2d126f2

@wmadden
wmadden enabled auto-merge (rebase) July 21, 2026 13:52
@wmadden
wmadden force-pushed the chore/bump-minor-lockfile branch from 2efdce4 to faffb25 Compare July 24, 2026 11:22

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills-contrib/publish-npm-version/SKILL.md`:
- Line 51: Insert a blank line immediately before the fenced bash command block
in the publish-npm-version documentation so the fence is separated from the
preceding paragraph and satisfies markdownlint MD031.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ccc223d1-ccfd-4e13-87ed-1642a6863a3f

📥 Commits

Reviewing files that changed from the base of the PR and between 2efdce4 and faffb25.

📒 Files selected for processing (4)
  • docs/oss/versioning.md
  • package.json
  • scripts/bump-minor.ts
  • skills-contrib/publish-npm-version/SKILL.md

Comment thread skills-contrib/publish-npm-version/SKILL.md
The v0.2.0 release PR (#143) went red across CI because the bump
rewrote workspace:<version> pins in every manifest but left
pnpm-lock.yaml at the old version, and CI installs with
--frozen-lockfile. bump-minor now runs `pnpm install --lockfile-only`
after set-version, the `pnpm bump-minor` script both docs already
reference actually exists, and the skill/versioning docs call out the
lockfile requirement.

Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@wmadden
wmadden force-pushed the chore/bump-minor-lockfile branch from faffb25 to 2d126f2 Compare July 24, 2026 11:33
@wmadden
wmadden disabled auto-merge July 24, 2026 11:46
@wmadden
wmadden merged commit f8a33c5 into main Jul 24, 2026
13 checks passed
@wmadden
wmadden deleted the chore/bump-minor-lockfile branch July 24, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants