Conversation
owen-eth
requested review from
aloknerurkar
and removed request for
aloknerurkar
Collaborator
aloknerurkar
left a comment
aloknerurkar
left a comment
There was a problem hiding this comment.
Nice work. Overall structure is good, comments are mostly minor.
| "gasLimit", gasLimit, | ||
| ) | ||
|
|
||
| return ÐSwapResponse{ |
Collaborator
There was a problem hiding this comment.
So we return the calldata and not enqueue the txn? Is this like some estimation request?
Contributor
Author
There was a problem hiding this comment.
When a user wants to swap using ETH we take the request, create the unsigned tx, then return it to the dapp for them to sign and submit since they are the ones executing tx in this case. (We submit ourselves for other inputs)
alok-ssv
approved these changes
Jan 27, 2026
aloknerurkar
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds two endpoints for FastSettlementV3 swap execution via Barter API integration:
/fastswap (Path 1 - Executor Submission for standard intent flow)
For ERC20→token swaps using Permit2 signatures.
-User signs intent off-chain with Permit2
-Request includes intent + signature
-Executor calls Barter API for optimal swap route
-Executor builds, signs, and submits executeWithPermit tx
-Returns tx hash
/fastswap/eth (User Submission)
For native ETH→token swaps where user must submit their own tx with ETH value.
-User requests swap quote with ETH amount + output token
-Server calls Barter API for route (using WETH internally)
-Returns unsigned executeWithETH calldata + gas estimate
-User signs and submits tx themselves
New flags:
--barter-api-url / --barter-api-key - Barter routing API
--fast-settlement-address - FastSettlementV3 contract
--fastswap-keystore-path - Separate executor wallet (For Path 1)
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review