Skip to content

Timeline: CommentCard uses shared MutedTime permalink helper #8141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janmaarten-a11y wants to merge 1 commit into
base: janmaarten-a11y-janmaarten-a11y-timeline-dependabot-shar
Choose a base branch
from
+2 −11
Open

Timeline: CommentCard uses shared MutedTime permalink helper #8141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/react/src/Timeline/internal/CommentCard.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,6 @@
color: var(--fgColor-muted);
}

/* Muted, underlined relative-time permalink. The underline keeps this muted
in-text link high-contrast accessible (matches the badge-row `.Timestamp`). */
.Timestamp {
text-decoration: underline;
}

.CardActions {
display: flex;
align-items: center;
Expand Down
7 changes: 2 additions & 5 deletions packages/react/src/Timeline/internal/CommentCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ import Avatar from '../../Avatar'
import {IconButton} from '../../Button'
import Label from '../../Label'
import Link from '../../Link'
import RelativeTime from '../../RelativeTime'
import Timeline from '../Timeline'
import {InlineAvatar} from './timelineStoryHelpers'
import {InlineAvatar, MutedTime} from './timelineStoryHelpers'
import classes from './CommentCard.module.css'

/**
Expand Down Expand Up @@ -207,9 +206,7 @@ export const CommentCard = ({
{hasInlineHeader ? <span className={classes.CommentedVerb}>commented</span> : null}
<span className={classes.TimestampLine}>
{/* Muted + underlined keeps this muted permalink high-contrast accessible. */}
<Link href="#" className={classes.Timestamp} muted>
<RelativeTime date={new Date(timestamp)} format="relative" />
</Link>
<MutedTime date={new Date(timestamp)} href="#" />
{viaApp ? (
<>
{' – with '}
Expand Down
Loading