[CSS Anchor Positioning] Disable feature flag if portalContainerName is true#7805
[CSS Anchor Positioning] Disable feature flag if portalContainerName is true#7805
portalContainerName is true#7805Conversation
🦋 Changeset detectedLatest commit: 301953d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/19933 |
There was a problem hiding this comment.
Pull request overview
This PR narrows when AnchoredOverlay uses CSS anchor positioning so overlays fall back to JS positioning when a named portal container is provided. It targets the overlay/portal integration in @primer/react, specifically the feature-flagged CSS anchor positioning path.
Changes:
- Gate
cssAnchorPositioningbehind the absence ofoverlayProps.portalContainerName. - Preserve existing popover/CSS-anchor behavior when no named portal container is supplied.
- Add a patch changeset describing the AnchoredOverlay behavior change.
Show a summary per file
| File | Description |
|---|---|
packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx |
Disables the CSS anchor positioning code path when overlayProps.portalContainerName is set. |
.changeset/evil-coins-tease.md |
Records the AnchoredOverlay behavior change for release notes. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
| const cssAnchorPositioning = | ||
| cssAnchorPositioningFlag && supportsNativeCSSAnchorPositioning && !overlayProps?.portalContainerName |
Closes https://github.com/github/primer/issues/6648
Disables
primer_react_css_anchor_positioningifportalContainerNameis true.Changelog
Changed
primer_react_css_anchor_positioningifportalContainerNameis present.Rollout strategy
Testing & Reviewing
Merge checklist