Skip to content

fix(Link): destructure muted prop to prevent unintentional DOM attribute leakage #7631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −2
Open

fix(Link): destructure muted prop to prevent unintentional DOM attribute leakage #7631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cbe863
Initial plan
Copilot Mar 6, 2026
ef90e83
fix(Link): destructure muted prop to prevent DOM leakage
Copilot Mar 6, 2026
61eb747
test(Link): assert bare muted attribute is not leaked to DOM
Copilot Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react/src/Link/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const UnwrappedLink = <As extends React.ElementType = 'a'>(
props: PolymorphicProps<As, 'a', StyledLinkProps>,
ref: ForwardedRef<unknown>,
) => {
const {as: Component = 'a', className, inline, hoverColor, ...restProps} = props
const {as: Component = 'a', className, inline, muted, hoverColor, ...restProps} = props
const innerRef = React.useRef<ElementRef<As>>(null)
useRefObjectAsForwardedRef(ref, innerRef)

Expand Down Expand Up @@ -49,7 +49,7 @@ export const UnwrappedLink = <As extends React.ElementType = 'a'>(
return (
<Component
className={clsx(className, classes.Link)}
data-muted={restProps.muted}
data-muted={muted}
data-inline={inline}
data-hover-color={hoverColor}
{...restProps}
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/Link/__tests__/Link.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ describe('Link', () => {
it('respects the "muted" prop', () => {
const {container} = render(<Link muted />)
expect(container.firstChild).toHaveAttribute('data-muted', 'true')
expect(container.firstChild).not.toHaveAttribute('muted')
})

it('logs a warning when trying to render invalid "as" prop', () => {
Expand Down