[Project2/조민철] Hex colors gradient#7
Open
datalater wants to merge 4 commits intoprgrms-web-devcourse:JSmini_datalaterfrom
Open
[Project2/조민철] Hex colors gradient#7datalater wants to merge 4 commits intoprgrms-web-devcourse:JSmini_datalaterfrom
datalater wants to merge 4 commits intoprgrms-web-devcourse:JSmini_datalaterfrom
Conversation
AlangGY
reviewed
Sep 13, 2021
02-hex-colors-gradient/main.js
Outdated
|
|
||
| const $button = document.getElementById('button'); | ||
|
|
||
| const randomHexColor = () => `#${Math.floor(Math.random() * (256 ** 3)).toString(16)}`; |
Member
There was a problem hiding this comment.
256**3(16 ** 6) 으로도 6자리수의 16진수값을 생성할수 있겠네요! 저는 2번 프로젝트에서도 동일하게 r,g,b를 따로 처리했었습니다.
Collaborator
Author
There was a problem hiding this comment.
넵 이번에는 rgb를 합친 전체 색상에 차례대로 인덱스를 붙인다고 생각하고 랜덤으로 인덱스를 선택하는 방식으로 처리해보았습니다ㅎㅎ
| index | color |
|---|---|
| 0 | #000000 |
| 1 | #000001 |
| ... | #... |
| 256 ** 3 -1 | #ffffff |
그런데 지금 보니 이게 # 뒤에 16진수 값이 6자리가 안 만들어질 수도 있겠네요!!!! 수정해서 반영하겠습니다.
Collaborator
Author
There was a problem hiding this comment.
제 예상과 다른 값이 발생하네요.
저는 256**3 = 16777216에 Math.random()을 곱하면 Math.random()의 최대값은 1미만이니까 절대 16777216은 안 나올줄 알았는데 아래와 같은 예외 케이스가 발생하네요
예외 케이스:
Math.floor(16777216 * 0.99999999999999999).toString(16)
// '1000000'일단 원인을 좀 더 알아보고 코드를 수정하도록 하겠습니다.
AlangGY
reviewed
Sep 13, 2021
| setInterval(() => { | ||
| $guideMessage.classList.toggle('change-color'); | ||
| $currentStyle.classList.toggle('change-color'); | ||
| }, 2000); |
Member
There was a problem hiding this comment.
애니메이션이 아니더라도 setInterval과 transition으로 애니메이션과 같은 효과를 줄수 있군요! 한가지 또 배워갑니다 ㅎ
Collaborator
Author
There was a problem hiding this comment.
오 애니메이션으로 하셨군요? 참고하러 보러가겠습니다 😀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIL
랜덤 색상값 추출 방법 변경
이전:
변경:
256**3)에서 한번에 랜덤으로 추출