[#138] refactor(container): Bevel 스크롤 컨테이너 분리/적용#141
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR extracts a common bevel + scroll wrapper pattern into a reusable BevelScrollContainer component and applies it across gallery, memo (post list), guestbook, and friend management screens to reduce code duplication.
Key changes:
- New
BevelScrollContainercomponent that encapsulates bevel styling with scrollable content area - Standardized padding to
p-4across all implementations (previously varied betweenp-3,p-3 pr-0,pl-4, etc.) - Simplified markup by replacing repetitive two-div patterns with a single component
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/Container/BevelScrollContainer.tsx | New reusable container component with bevel border and scrollable content area |
| src/features/minihome/post/list/PostList.tsx | Applied BevelScrollContainer to post list, replacing previous bevel+scroll wrapper |
| src/features/minihome/guestbook/GuestBook.tsx | Applied BevelScrollContainer to guestbook list with flex wrapper |
| src/features/minihome/gallery/GalleryList.tsx | Applied BevelScrollContainer to gallery grid view |
| src/features/friends/search/Search.tsx | Applied BevelScrollContainer to friend search results with flex wrapper |
| src/features/friends/request/Request.tsx | Applied BevelScrollContainer to friend request list with flex wrapper |
| src/features/friends/list/List.tsx | Applied BevelScrollContainer to friend list with flex wrapper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RumPumpumpum
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 개요
BevelScrollContainer로 분리하고 갤러리/메모/방명록/친구창 리스트 영역에 공통 적용했습니다.✅ 관련 이슈
🛠️ 상세 작업 내용
src/components/Container/BevelScrollContainer.tsx추가📸 스크린샷
👥 리뷰 확인 사항
공통적으로 갤러리의 스타일인 p-4를 적용했습니다.