Skip to content

System tests: More robust setup of DUNE modules#780

Merged
MakisH merged 3 commits into
developfrom
dune-gitlab-requests
May 14, 2026
Merged

System tests: More robust setup of DUNE modules#780
MakisH merged 3 commits into
developfrom
dune-gitlab-requests

Conversation

@MakisH
Copy link
Copy Markdown
Member

@MakisH MakisH commented May 13, 2026

  • Split the git clones into multiple Docker run steps
  • Retry if a git clone fails, for three times, with delay

I am only adding this to the Ubuntu 24.04 Dockerfile, since we anyway don't have this in 22.04.

Workaround (partial fix) for #768

GitHub Actions run: https://github.com/precice/tutorials/actions/runs/25845382737

Note that the two-scale-heat-conduction test is known to fail at the fieldcompare test. I am executing the dumux-test instead of the release-test, for convenience.

@MakisH MakisH self-assigned this May 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the Ubuntu 24.04 system-test Docker setup for DuMuX/DUNE more resilient to transient clone failures, aligning with the workaround requested for network-related artifact retrieval failures.

Changes:

  • Splits the DUNE/DuMuX repository clones into separate Docker RUN layers.
  • Adds intended retry behavior with delay and cleanup around each git clone.
  • Keeps the subsequent DuMuX adapter build flow unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile Outdated
Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 9 comments.

Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile Outdated
Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile Outdated
Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile
Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile
Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile Outdated
Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile Outdated
Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile Outdated
Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile Outdated
Comment thread tools/tests/dockerfiles/ubuntu_2404/Dockerfile Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@MakisH MakisH merged commit 62c959c into develop May 14, 2026
2 of 3 checks passed
@MakisH MakisH deleted the dune-gitlab-requests branch May 14, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants