Add per-test max_time override for system tests#744
Conversation
|
@MakisH Plz review |
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-aditya-gupta/2773/4 |
|
How does this PR relate to the previously opened #738? |
|
@MakisH yes PR tackles the same issue as #738. I opened it separately because I wanted to keep the scope focused just the max_time override, without the iterations-log changes that #738 also includes. |
MakisH
left a comment
There was a problem hiding this comment.
FYI, this PR (and some other) could benefit from:
- A short explanation of the main idea:
- Reads a
max-timevalue fromtests.yaml - Overwrites the value in the
precice-config.xmlwhile preparing the case to run.
- Reads a
- Some Markdown formatting, especially where you show code.
Given my previous comment on the relation to another PR (#744 (comment)), note that I still need to review the other PR as well. Maybe don't rush implementing everything.
8201a5c to
4c199dd
Compare
4c199dd to
8a96d5b
Compare
MakisH
left a comment
There was a problem hiding this comment.
I tested this locally for max_time, and it works. Everything else looks good now.
Note that fieldcompare fails due to missing source files. I tried adding --ignore-missing-source-files, but then it still fails in the last time window, since the behavior is a bit different (probably a bug in the OpenFOAM adapter) and gave an error of just above the tolerance. This means that we cannot reuse the same reference results without some handling, but it is still useful for more complex cases.
Thanks again for contributing!
What this PR does
Adds an optional
max_timefield to entries intests.yamlto cap preCICE simulation time per test case.How it works:
max_timevalue fromtests.yaml<max-time>(or<max-time-windows>) value inprecice-config.xmlwhile preparing the case to runCloses #402
Checklist
changelog-entries/402.md