System tests: Archive fieldcompare diff files on failure#740
Conversation
MakisH
added
GSoC
PranjalManhgaye
changed the title
PranjalManhgaye
changed the title
PranjalManhgaye
force-pushed
the
issue-441-archive-fieldcompare-diffs
branch
from
44fb3ea to
a904f4f
Compare
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-pranjal-manhgaye/2769/6 |
MakisH
changed the title
MakisH
changed the title
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds automatic archiving of fieldcompare-generated VTK diff files into a dedicated folder to make CI artifact debugging easier when comparisons fail.
Changes:
- Add logic to collect and copy
*diff*.(vtu|vtk|vtp)files intodiff-results/when fieldcompare fails. - Invoke the archiving step during systemtest failure handling.
- Document the new
diff-results/behavior in the systemtests README and add a changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tools/tests/systemtests/Systemtest.py | Copies fieldcompare diff VTK files into diff-results/ on fieldcompare failure. |
| tools/tests/README.md | Documents where to find diff VTK files in CI artifacts for debugging. |
| changelog-entries/441.md | Notes the user-facing behavior change for archiving diff files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@PranjalManhgaye could you please have a look at the copilot comments in this PR? |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Move DIFF_RESULTS_DIR below imports; archive with rglob and preserve precice-exports/ paths under diff-results/; lazy debug log once after copy; README clarifies archiving only runs on fieldcompare failure.
|
yea i pushed an update that should cover the Copilot points (recursive copy under precice-exports/, paths preserved under diff-results/, README only on failure, constant + logging tidy‑ups) , could you take another look when you have time , thanks |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
I tested this locally, and it works as expected. Thanks!
Summary
Implements #441: archive fieldcompare diff VTK files so they are easy to find in CI artifacts when a comparison fails.
Changes
*diff*.vtu,*diff*.vtk, and*diff*.vtpfiles from precice-exports/ into adiff-results/folder in the same run directory.diff-results/for inspection (e.g. in ParaView) when debugging comparison failures.Checklist