Add FEniCSx solver for partitioned heat conduction tutorial#687
Add FEniCSx solver for partitioned heat conduction tutorial#687NiklasVin wants to merge 11 commits intoprecice:developfrom
Conversation
|
This PR is to be merged only after fenicsxprecice is released and available via pip. |
Move the tutorials to https://github.com/precice/tutorials. See precice/tutorials#687, precice/tutorials#688 and precice/tutorials#714 --------- Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
IshaanDesai
left a comment
There was a problem hiding this comment.
Looks good in general. My suggestions are mainly cosmetic. I ran the tutorial and it runs, but at the end the error is higher than the tolerance.
L2-error: 3.56e+08
Error_max: 3.00e+10
Traceback (most recent call last):
File "/home/desaiin/tutorials/partitioned-heat-conduction/dirichlet-fenicsx/../solver-fenicsx/heat.py", line 304, in <module>
error, error_pointwise = compute_errors(u_n, u_ref, total_error_tol=error_tol)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/desaiin/tutorials/partitioned-heat-conduction/solver-fenicsx/errorcomputation.py", line 19, in compute_errors
assert (error_L2 < total_error_tol)
^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionErrorshall we lower the tolerance?
How did you run the tutorial? |
I ran the tutorial by running |
Checklist:
changelog-entries/<PRnumber>.md.