Skip to content

Make participant argument optional, analyze all if omitted #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fsimonis merged 9 commits into from
Mar 9, 2026
Merged

Make participant argument optional, analyze all if omitted #24

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
49cbfe5
Fix: translate 'total' to '_GLOBAL' for --event argument (#18)
AdityaGupta716 Feb 25, 2026
7ae4f26
Fix: make participant argument optional, analyze all if omitted (#7)
AdityaGupta716 Feb 25, 2026
3ca82be
Merge branch 'main' into issue-7-optional-participant
AdityaGupta716 Feb 27, 2026
b974ea3
Apply black formatting
AdityaGupta716 Feb 27, 2026
38603b8
Fix: error on --output without participant, pass None instead of outf…
AdityaGupta716 Mar 8, 2026
a97b363
Test: add tests for optional participant and outfile error
AdityaGupta716 Mar 8, 2026
967713e
Refactor: extract computeAnalysis to eliminate recursive analyzeComma…
AdityaGupta716 Mar 8, 2026
0e293f4
Refactor: move print and assertion per reviewer feedback
AdityaGupta716 Mar 8, 2026
cab3ca2
Apply black formatting
AdityaGupta716 Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions preciceprofiling/analyze.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@ def makeAnalyzeParser(add_help: bool = True):
Parallel solvers show events of the primary rank next to the secondary ranks spending the least and most time in advance of preCICE.
"""
analyze = argparse.ArgumentParser(description=analyze_help, add_help=add_help)
analyze.add_argument("participant", type=str, help="The participant to analyze")
analyze.add_argument(
"participant",
type=str,
nargs="?",
default=None,
help="The participant to analyze. If omitted, all participants are analyzed.",
)
addInputArgument(analyze)
addUnitArgument(analyze)
analyze.add_argument(
Expand Down Expand Up @@ -123,11 +129,18 @@ def analyzeCommand(profilingfile, participant, event, outfile=None, unit="us"):

run = Run(profilingfile)

participants = run.participants()
all_participants = run.participants()

if participant is None:
for p in all_participants:
print(f"\n=== Participant: {p} ===")
analyzeCommand(profilingfile, p, event, outfile, unit)
Comment thread
AdityaGupta716 marked this conversation as resolved.
Outdated
return 0

assert (
participant in participants
participant in all_participants
), f"Given participant {participant} doesn't exist. Known: " + ", ".join(
participants
all_participants
)

df = run.toDataFrame(participant=participant)
Expand Down