Skip to content

Add profiling merge example without arguments#846

Open
fsimonis wants to merge 1 commit intomasterfrom
add-argumentless-merge-ex
Open

Add profiling merge example without arguments#846
fsimonis wants to merge 1 commit intomasterfrom
add-argumentless-merge-ex

Conversation

@fsimonis
Copy link
Member

The first example used merge with arguments, which can be misunderstood to be the Participants to merge.

We now

  • first show the non-argument version that should be enough in most cases.
  • then explain what arguments mean
  • and finally show the example with arguments

@fsimonis fsimonis requested a review from carme-hp March 11, 2026 14:55
Copy link
Member

@carme-hp carme-hp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd just asked you to add more on the default.

@@ -228,6 +229,24 @@ profiling.db

The merge command searches passed directories for the event files.
Copy link
Member

@carme-hp carme-hp Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the default directory if nothing is specified? I get that you are looking at the current directory, but I think it is not obvious that it searches inside subdirectories as well.

@MakisH MakisH added the content Content-only issues label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Content-only issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants