Skip to content

Test: Allow duplicate cookie family names #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marki1an wants to merge 12 commits into
base: allow-duplicate-cookie-family-names
Choose a base branch
from
+73 −10
Open

Test: Allow duplicate cookie family names #4360

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
535e811
Add coverage for allow duplicate cookie family names
marki1an Jan 27, 2026
b1bd6aa
Remove redundant imports
marki1an Jan 27, 2026
eaffb58
Add coverage for aliases
marki1an Jan 27, 2026
1f89ec1
Update after review
marki1an Jan 28, 2026
2360fb1
Update after review
marki1an Jan 29, 2026
58f0fcd
Last updated
marki1an Jan 29, 2026
877978f
Revert config
marki1an Feb 3, 2026
88f90d7
Minor update after review
marki1an Feb 24, 2026
e1ddfa7
Merge remote-tracking branch 'refs/remotes/origin/master' into tests/…
marki1an Feb 24, 2026
b5d42e2
Remove empty line
marki1an Feb 24, 2026
cfb395e
Merge remote-tracking branch 'origin/master' into tests/allow-duplica…
marki1an Mar 2, 2026
3c36034
Merge remote-tracking branch 'origin/allow-duplicate-cookie-family-na…
marki1an Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 73 additions & 10 deletions src/test/groovy/org/prebid/server/functional/tests/SetUidSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ import static org.prebid.server.functional.model.bidder.BidderName.ALIAS_CAMEL_C
import static org.prebid.server.functional.model.bidder.BidderName.APPNEXUS
import static org.prebid.server.functional.model.bidder.BidderName.GENERIC
import static org.prebid.server.functional.model.bidder.BidderName.GENERIC_CAMEL_CASE
import static org.prebid.server.functional.model.bidder.BidderName.GRID
import static org.prebid.server.functional.model.bidder.BidderName.OPENX
import static org.prebid.server.functional.model.bidder.BidderName.OPENX_ALIAS
import static org.prebid.server.functional.model.bidder.BidderName.RUBICON
import static org.prebid.server.functional.model.bidder.BidderName.UNKNOWN
import static org.prebid.server.functional.model.bidder.BidderName.WILDCARD
Expand All @@ -38,21 +40,50 @@ class SetUidSpec extends BaseSpec {
private static final boolean CORS_SUPPORT = false
private static final Integer RANDOM_EXPIRE_DAY = PBSUtils.getRandomNumber(1, 10)
private static final String USER_SYNC_URL = "$networkServiceContainer.rootUri/generic-usersync"
private static final Map<String, String> PBS_CONFIG =
["host-cookie.max-cookie-size-bytes" : MAX_COOKIE_SIZE as String,
"adapters.${RUBICON.value}.enabled" : "true",
"adapters.${RUBICON.value}.usersync.cookie-family-name" : RUBICON.value,
"adapters.${OPENX.value}.enabled" : "true",
"adapters.${OPENX.value}.usersync.cookie-family-name" : OPENX.value,
"adapters.${APPNEXUS.value}.enabled" : "true",
"adapters.${APPNEXUS.value}.usersync.cookie-family-name" : APPNEXUS.value,
"adapters.${GENERIC.value}.usersync.${USER_SYNC_TYPE.value}.url" : USER_SYNC_URL,
"adapters.${GENERIC.value}.usersync.${USER_SYNC_TYPE.value}.support-cors": CORS_SUPPORT.toString()]
private static final String GENERIC_COOKIE_FAMILY_NAME = GENERIC.value
private static final String VENDOR_ID = PBSUtils.randomNumber as String
private static final Map<String, String> UID_COOKIES_CONFIG = ['setuid.number-of-uid-cookies': MAX_NUMBER_OF_UID_COOKIES.toString()]
private static final Map<String, String> GENERIC_ALIAS_CONFIG = ["adapters.generic.aliases.alias.enabled" : "true",
"adapters.generic.aliases.alias.endpoint": "$networkServiceContainer.rootUri/auction".toString()]
private static final String TCF_ERROR_MESSAGE = "The gdpr_consent param prevents cookies from being saved"
private static final int UNAVAILABLE_FOR_LEGAL_REASONS_CODE = 451
private static final Map<String, String> PBS_CONFIG =
["host-cookie.max-cookie-size-bytes" : MAX_COOKIE_SIZE as String,

"adapters.${RUBICON.value}.enabled" : "true",
"adapters.${RUBICON.value}.usersync.cookie-family-name" : RUBICON.value,

"adapters.${OPENX.value}.enabled" : "true",
"adapters.${OPENX.value}.usersync.cookie-family-name" : OPENX.value,

"adapters.${APPNEXUS.value}.enabled" : "true",
"adapters.${APPNEXUS.value}.usersync.cookie-family-name" : APPNEXUS.value,

"adapters.${GENERIC.value}.meta-info.vendor-id" : VENDOR_ID,
"adapters.${GENERIC.value}.usersync.cookie-family-name" : GENERIC_COOKIE_FAMILY_NAME,
"adapters.${GENERIC.value}.usersync.${USER_SYNC_TYPE.value}.url" : USER_SYNC_URL,
"adapters.${GENERIC.value}.usersync.${USER_SYNC_TYPE.value}.support-cors" : CORS_SUPPORT.toString(),

"adapters.${GRID.value}.enabled" : "true",
"adapters.${GRID.value}.meta-info.vendor-id" : VENDOR_ID,
"adapters.${GRID.value}.usersync.cookie-family-name" : GENERIC_COOKIE_FAMILY_NAME,
"adapters.${GRID.value}.usersync.${USER_SYNC_TYPE.value}.url" : USER_SYNC_URL,
"adapters.${GRID.value}.usersync.${USER_SYNC_TYPE.value}.support-cors" : CORS_SUPPORT.toString(),
Copy link
Collaborator

@osulzhenko osulzhenko Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need add:
"adapters.${GRID.value}.usersync.${USER_SYNC_TYPE.value}.uid-macro" : "",

"adapters.${GRID.value}.usersync.${USER_SYNC_TYPE.value}.uid-macro" : "",

"adapters.${GENERIC}.aliases.${ALIAS}.enabled" : "true",
"adapters.${GENERIC}.aliases.${ALIAS}.endpoint" : "$networkServiceContainer.rootUri/auction".toString(),
"adapters.${GENERIC}.aliases.${ALIAS}.meta-info.vendor-id" : VENDOR_ID,
"adapters.${GENERIC}.aliases.${ALIAS}.usersync.cookie-family-name" : GENERIC_COOKIE_FAMILY_NAME,
"adapters.${GENERIC}.aliases.${ALIAS}.usersync.${USER_SYNC_TYPE.value}.url" : USER_SYNC_URL,
"adapters.${GENERIC}.aliases.${ALIAS}.usersync.${USER_SYNC_TYPE.value}.support-cors" : CORS_SUPPORT.toString(),

"adapters.${GENERIC}.aliases.${OPENX_ALIAS}.enabled" : "true",
"adapters.${GENERIC}.aliases.${OPENX_ALIAS}.endpoint" : "$networkServiceContainer.rootUri/auction".toString(),
"adapters.${GENERIC}.aliases.${OPENX_ALIAS}.meta-info.vendor-id" : VENDOR_ID,
"adapters.${GENERIC}.aliases.${OPENX_ALIAS}.usersync.cookie-family-name" : GENERIC_COOKIE_FAMILY_NAME,
"adapters.${GENERIC}.aliases.${OPENX_ALIAS}.usersync.${USER_SYNC_TYPE.value}.url" : USER_SYNC_URL,
"adapters.${GENERIC}.aliases.${OPENX_ALIAS}.usersync.${USER_SYNC_TYPE.value}.support-cors": CORS_SUPPORT.toString()]

@Shared
PrebidServerService singleCookiesPbsService = pbsServiceFactory.getService(PBS_CONFIG + GENERIC_ALIAS_CONFIG)
Expand Down Expand Up @@ -513,6 +544,38 @@ class SetUidSpec extends BaseSpec {
assert getSetUidsHeaders(response, true).size() == MAX_NUMBER_OF_UID_COOKIES
}

def "PBS shouldn't failed with error when adapters has same user sync and vendor id config"() {
given: "Default set uid request"
def request = SetuidRequest.defaultSetuidRequest

and: "Default uids cookie generic and adtrgtme"
def genericUidsCookie = UidsCookie.getDefaultUidsCookie(GENERIC)
def gridUidsCookie = UidsCookie.getDefaultUidsCookie(GRID)

when: "PBS processes auction request"
def response = singleCookiesPbsService.sendSetUidRequest(request, [gridUidsCookie, genericUidsCookie])

then: "Response should contain requested tempUIDs"
assert response.uidsCookie.tempUIDs[GENERIC]
assert response.uidsCookie.tempUIDs[GRID]
}

def "PBS shouldn't failed with error when alias adapters has same user sync and vendor id config"() {
given: "Default set uid request"
def request = SetuidRequest.defaultSetuidRequest

and: "Default uids cookie generic alias and opnex alias"
def genericAliasUidsCookie = UidsCookie.getDefaultUidsCookie(ALIAS)
def genericOpenxAliasUidsCookie = UidsCookie.getDefaultUidsCookie(OPENX_ALIAS)

when: "PBS processes auction request"
def response = singleCookiesPbsService.sendSetUidRequest(request, [genericAliasUidsCookie, genericOpenxAliasUidsCookie])

then: "Response should contain requested tempUIDs"
assert response.uidsCookie.tempUIDs[ALIAS]
assert response.uidsCookie.tempUIDs[OPENX_ALIAS]
}

List<String> getSetUidsHeaders(SetuidResponse response, boolean includeEmpty = false) {
response.headers.get("Set-Cookie").findAll { cookie ->
includeEmpty || !(cookie =~ /\buids\d*=\s*;/)
Expand Down