ReVantage Bid Adapter: Add revbidortb alias#14972
Conversation
Fixed trailing slash Error on Line 123
Fixed Trailing slashes (again)
same thing again
Refactor Revantage Bid Adapter to use media type constants and improve bid response handling.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added validation to ensure all bid requests in a batch have the same feedId, logging a warning if they do not.
Added functions to handle video size extraction and VAST detection.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an alias for the Revantage bidder adapter and updates an inline comment in the request-building logic.
Changes:
- Added
aliasesentry (revbidortb) to the bidderspec. - Introduced a typo in the comment above the empty-request guard in
buildRequests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| buildRequests: function(validBidRequests, bidderRequest) { | ||
| // Handle null/empty bid requests | ||
| // Handle null/empty bid requestsa |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3ae506cd1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| gvlid: 1588, | ||
| aliases: ['revbidortb'], |
There was a problem hiding this comment.
When publishers use bidder: 'revbidortb' under the TCF control module, this string alias is registered with no GVL ID: registerBidder only copies alias.gvlid for object aliases and otherwise passes undefined into the aliased spec. That means GDPR_GVLIDS.get('revbidortb') has no vendor 1588, so Revantage's vendor consent cannot be enforced for traffic using the new alias. Please define the alias as an object with gvlid: 1588.
Useful? React with 👍 / 👎.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information