Zeta Global Analytics Adapter: extra events#14964
Conversation
Extract shared site-context, floor, mediaType, and device helpers so analytics events send complete fields (including auctionId on bidsReceived) with robust page/domain fallbacks and bounded bidder error payloads. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
1 similar comment
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d5e1b3922
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| function resolveTimeoutSiteContext(timeouts = []) { | ||
| const siteBid = timeouts.find(t => t?.ortb2?.site?.page || t?.ortb2?.site?.domain); |
There was a problem hiding this comment.
When the BID_TIMEOUT payload contains partial ortb2.site data, this picks the first timeout that has either page or domain and then reads both fields from that one bid. For example, if the first timed-out bid has only site.domain and a later one has site.page, the page now falls back to getRefererInfo().page instead of using the page present in the timeout array; the previous code searched for page and domain separately, so this regresses the accuracy of the timeout analytics payload for partially populated site objects.
Useful? React with 👍 / 👎.
1 participant
Type of change
Description of change
Support for events: