Skip to content

Fix extra v in golang tags #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asottile merged 1 commit into from
Jan 14, 2026
Merged

Fix extra v in golang tags #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pre_commit_mirror_maker/languages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ def golang_get_package_versions(package_name: str) -> list[str]:
)
url = f'https://proxy.golang.org/{escaped}/@v/list'
resp = urllib.request.urlopen(url).read().decode()
return sorted(resp.splitlines(), key=version.parse)
return sorted(
(v.removeprefix('v') for v in resp.splitlines()),
key=version.parse,
)


def node_get_additional_dependencies(
Expand All @@ -61,7 +64,7 @@ def rust_get_additional_dependencies(
def golang_get_additional_dependencies(
package_name: str, package_version: str,
) -> list[str]:
return [f'{package_name}@{package_version}']
return [f'{package_name}@v{package_version}']


LIST_VERSIONS = {
Expand Down
1 change: 1 addition & 0 deletions tests/languages_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,5 @@ def test_rust_get_package_version_output():
def test_golang_get_package_version_output():
ret = golang_get_package_versions('mvdan.cc/gofumpt')
assert ret
assert not any(v.startswith('v') for v in ret)
assert_all_text(ret)