Add support for *.hlsl and *.hlsli#572
Merged
asottile merged 1 commit intopre-commit:mainfrom Feb 20, 2026
Merged
Conversation
asottile
reviewed
Feb 20, 2026
identify/extensions.py
Outdated
| 'hbs': {'text', 'handlebars'}, | ||
| 'hcl': {'text', 'hcl'}, | ||
| 'hlsl': {'text', 'hlsl'}, | ||
| 'hlsli': {'text', 'header', 'hlsl'}, |
Member
There was a problem hiding this comment.
generally header is meant for c / c++ headers and really isn't that useful of a tag so I'm not adding it to new things
Contributor
Author
There was a problem hiding this comment.
That's fine by me, I only included it because it already existed, and to be able to potentially differentiate between the two extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation: https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl
I did not find any direct source in the above docs saying that
.hlslis the standard extension, but Google's not giving me anything else, so it seem unambigiouos enough.I've found this on the Stack Overflow answer on the
.hlsl/.hlslidistinction though, and it matches existing practice I've seen in the wild: https://stackoverflow.com/questions/46809070/what-is-the-difference-between-hlsl-and-hlsli