Do not sort OrderedDict keyword arguments#51
Merged
Conversation
OrderedDict(b=2, a=1) iterates in argument order and is a distinct, unequal value from OrderedDict(a=1, b=2), so alphabetizing its keyword arguments changed the resulting object. Exempt calls to OrderedDict (bare or dotted, such as collections.OrderedDict) from keyword-argument sorting via a new ORDER_SENSITIVE_CALLS set. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OrderedDict(b=2, a=1)iterates in argument order and is a distinct, unequal value fromOrderedDict(a=1, b=2), so alphabetizing its keyword arguments changed the resulting object.This exempts calls to
OrderedDict(bare or dotted, e.g.collections.OrderedDict) from keyword-argument sorting via a newORDER_SENSITIVE_CALLSset. Atest_order_sensitive_callsfixture covers both forms alongside the regular-call and dict-literal cases that must still sort.