Skip to content

Remove concurrency from the reusable lint workflow - #37

Merged
bboe merged 1 commit into
mainfrom
fix-reusable-lint-startup-failure
Aug 12, 2026
Merged

Remove concurrency from the reusable lint workflow#37
bboe merged 1 commit into
mainfrom
fix-reusable-lint-startup-failure

Conversation

@bboe

@bboe bboe commented Aug 12, 2026

Copy link
Copy Markdown
Member

Fixes a silent breakage: Lint workflows has failed at startup in every caller repo since 2026-06-15, so actionlint and zizmor have not run on praw, prawcore, asyncpraw, asyncprawcore, CodeSorter, or praw-release for nearly two months.

Cause

v1.6.0 added a workflow-level concurrency block to the reusable lint.yml. Callers already declare the same lint-${{ github.ref }} group and then call this workflow, which declares it again. Called that way, the run fails at startup — no jobs, no logs, and no check run, which is why it never appeared in gh pr checks and never blocked anything. The workflow still ran fine in-repo, which masked it further.

Timeline: last success 2026-06-15T17:29Z; first failure 17:29 → 18:02Z, the minute the callers were bumped to v1.6.0. Every run since has failed.

Verification

Pointed CodeSorter's lint caller at this change (run 31614199429): the run started and both actionlint and zizmor completed successfully, versus a startup failure with zero jobs on the same caller minutes earlier.

Nothing is lost — every caller declares its own concurrency group.

Declaring workflow-level concurrency in a reusable workflow made every
workflow_call of it fail at startup: no jobs ran, no logs were produced, and
no check run was created, so the failure was invisible in PR checks and never
blocked a merge. actionlint and zizmor have therefore not run in any caller
repository since 2026-06-15, when the callers moved to v1.6.0.

Callers already declare their own concurrency group, so nothing is lost.

Verified by pointing CodeSorter's caller at this change: the run started and
both jobs completed, where the same caller had produced a startup failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant