Harden GitHub Actions workflows#21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the org's shared GitHub Actions workflows, surfaced by running zizmor across all praw-dev repos.
Changes
GITHUB_TOKENpermissions to the job level instale_action.ymlandtag_release.yml. Thepermissions:blocks were declared at the workflow level (granting the token to every job); they now sit on the specific job, with a deny-allpermissions: {}default at the top level. Resolves zizmor's high-severityexcessive-permissionsfindings and adds explanatory comments (undocumented-permissions). No functional change to the granted scopes.lint.ymlreusable by adding aworkflow_call:trigger (alongside the existingpush/pull_request), so theactionlint+zizmorjobs can be called from the other praw-dev repos. This repo continues to lint itself via the same file.Follow-up
Once this is released, the other repos will gain a thin
lint.ymlcaller pinned to the new release, bringing zizmor/actionlint coverage to every repo.