liboqs: Normalize return codes to OQS_STATUS#1298
Merged
Merged
Conversation
Collapse any nonzero result to OQS_ERROR in the sig_glue.c shims, since OQS_STATUS is a closed enum and mldsa-native returns a wider error set. Add a keypair shim so keypair is normalized too rather than wired directly to the mldsa-native symbol. - Resolves #1296 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Contributor
CBMC Results (ML-DSA-44)Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (210 proofs)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (210 proofs)
|
mkannwischer
marked this pull request as ready for review
July 17, 2026 11:43
hanno-becker
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse any nonzero result to OQS_ERROR in the sig_glue.c shims, since OQS_STATUS is a closed enum and mldsa-native returns a wider error set. Add a keypair shim so keypair is normalized too rather than wired directly to the mldsa-native symbol.