CI: Minimize workflow permissions and secrets#1294
Draft
hanno-becker wants to merge 1 commit into
Draft
Conversation
The goal of this commit is to minimize the permissions granted to CI tasks without impacting their current functionality. - Remove `id-token: write` from those jobs that do interface with EC2: base, lint-markdown, nix, riscv, oqs/awslc integration, ct-test, baremetal, zephyr, isabelle, awslc-main. Keep it in for: ci, cbmc, slothy, pavona, scorecard. - Replace broad "secrets: inherit" with an explicit AWS_GITHUB_TOKEN passing. - Narrow the PR/merge-queue nix job to `actions: read`; stick with `actions: write` only on the main-only nix_cache path that saves the cache. While at it, we also add tag comments to the pinned versions of donatj/symlink-check-action and zephyr actions/checkout. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this commit is to minimize the permissions granted to CI tasks without impacting their current functionality.
id-token: writefrom those jobs that do interface with EC2: base, lint-markdown, nix, riscv, oqs/awslc integration, ct-test, baremetal, zephyr, isabelle, awslc-main. Keep it in for: ci, cbmc, slothy, pavona, scorecard.actions: read; stick withactions: writeonly on the main-only nix_cache path that saves the cache.While at it, we also add tag comments to the pinned versions of donatj/symlink-check-action and zephyr actions/checkout.