Remove crypto_sign_* API aliases and MLD_CONFIG_NO_SUPERCOP#1248
Merged
Conversation
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (205 proofs)
|
hanno-becker
reviewed
Jul 2, 2026
ed58dd1 to
9bf9f1f
Compare
Contributor
|
@mkannwischer I took the liberty to rebase this atop #1206 instead of #1240. |
hanno-becker
reviewed
Jul 4, 2026
9bf9f1f to
a2b12f7
Compare
a2b12f7 to
4b534af
Compare
mldsa_native.h exposed the public API under the crypto_sign_* SUPERCOP
naming scheme, gated by MLD_CONFIG_NO_SUPERCOP. Of these, only
crypto_sign_keypair (with the already-removed crypto_sign / crypto_sign_open)
was an actual SUPERCOP API; the signature/verify variants were mldsa-native
additions stapled onto the same prefix.
This commit removes those aliases, the MLD_CONFIG_NO_SUPERCOP configuration,
and the CRYPTO_{PUBLICKEY,SECRETKEY,}BYTES size constants -- the last remnant
of the SUPERCOP naming -- along with the related documentation and #error
messages.
Consumers and tests now use the native namespaced API directly. Examples call
the namespaced functions (e.g. mldsa_keypair); tests reconstruct the names via
test/src/test_namespace.h. For the key and signature sizes, examples and tests
derive them from MLD_CONFIG_PARAMETER_SET via local MLDSA_{PK,SK,SIG}_BYTES
abbreviations, since they are built for all parameter sets (44, 65, 87).
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
4b534af to
80954b4
Compare
hanno-becker
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto_sign_*API aliases andMLD_CONFIG_NO_SUPERCOP#1249mldsa_native.h exposed the public API under the crypto_sign_* naming
scheme, gated by MLD_CONFIG_NO_SUPERCOP.
Of these, only crypto_sign_keypair -- together with the already-removed
crypto_sign and crypto_sign_open -- is an actual SUPERCOP API.
crypto_sign_signature and crypto_sign_verify (and the _internal / _extmu /
pre_hash variants used by the tests) were mldsa-native additions stapled
on top of the same crypto_sign prefix.
This commit removes those aliases and the MLD_CONFIG_NO_SUPERCOP configuration
entirely, along with the related documentation in mldsa_native_config.h,
the example configs/READMEs, and the #error messages in common.h.
The CRYPTO_{PUBLICKEY,SECRETKEY,}BYTES size constants are retained in
mldsa_native.h as plain size macros (derived from MLD_CONFIG_PARAMETER_SET
for single-parameter-set builds), decoupled from the removed aliases.
Consumers and tests now use the native namespaced API directly:
per-parameter namespace currently cannot be removed due to the
check-namespace tests the building of libmldsa.a.