Support randomized Wycheproof signing vectors#1235
Merged
mkannwischer merged 1 commit intoJul 14, 2026
Conversation
This was referenced Jun 26, 2026
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (206 proofs)
|
959eec9 to
e9a522e
Compare
mkannwischer
requested changes
Jun 29, 2026
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
Thanks @fegge - this is a nice addition and the core looks correct to me.
Can you please get it through CI?
mkannwischer
requested changes
Jul 1, 2026
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
Thanks @fegge.
The changes look good to me now! Could you kindly combine your two commits? We are using Rebase and merge only and would like to keep the history cleaned up.
Bump the pinned Wycheproof commit to include randomized ML-DSA signing vectors, pass optional vector-provided rnd values to the signing driver, and cache vector files under a per-commit directory so they refresh when the pin changes. Signed-off-by: Fredrik Dahlgren <fredrik.dahlgren@trailofbits.com>
bd87099 to
350171d
Compare
mkannwischer
approved these changes
Jul 14, 2026
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
I took the liberty to rebase your changes on top of main and squash your second commit into the first one.
Thanks again for this improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rndvalues to the local signing driver and validate malformedrndinputs.Validation
ruff format test/wycheproof/wycheproof_client.py: passedruff check test/wycheproof/wycheproof_client.py: passedpython3 -m py_compile test/wycheproof/wycheproof_client.py: passedclang-format -i test/wycheproof/wycheproof_mldsa.c: passedgit diff --check -- test/wycheproof/wycheproof_client.py test/wycheproof/wycheproof_mldsa.c: passedmake wycheproof -j4: passedmake run_wycheproof -j4: passed, including refreshed randomized signing vectors such as ML-DSA-44tcId=90rndand malformedrndacrosssigGenSeedDeterministic,sigGenDeterministic, andsigGenInternalDeterministic: passed./scripts/formatbecausenixpkgs-fmtis not installed in this local environment./scripts/lintbecauseshfmtis not installed in this local environmentFixes #1219
This work was completed by Trail of Bits as part of the Patch The Planet project in collaboration with OpenAI. The issue was identified primarily by the Codex coding agent, and manually reviewed before submission.