fix: stop exposing WebSocket auth token to unauthenticated UI callers#25
Closed
fix: stop exposing WebSocket auth token to unauthenticated UI callers#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
format_ws_urlreturn a token-less endpoint (ws://.../ws) and addformat_ws_url_with_authto build a tokenized URL when needed for state-file compatibility.HttpOnlycookie and redirects to/uiand/uialso sets the same cookie so browser loads can authenticate without query secrets./wseither via the original?token=query (backwards compatibility) or via the newagent_tui_ws_tokencookie, implemented with helper functionsws_auth_cookieandread_cookie_value.Testing
cd cli && cargo test -p agent-tui-app ws_server -- --nocaptureand all relevant tests passed (9 tests, 0 failed).cd cli && cargo fmt --allto format code.Codex Task