Skip to content

Use new build/release/patch generic workflows. Move DYNAWO_VERSION out of workflow#14

Open
jonenst wants to merge 3 commits into
mainfrom
newrelease
Open

Use new build/release/patch generic workflows. Move DYNAWO_VERSION out of workflow#14
jonenst wants to merge 3 commits into
mainfrom
newrelease

Conversation

@jonenst
Copy link
Copy Markdown
Contributor

@jonenst jonenst commented Feb 26, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

NO

What kind of change does this PR introduce?

Feature

Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?

  • Yes, the corresponding issue is here
  • No

What is the current behavior?

CI/CD triggerd by git tag
CI/CD duplicated in multiple repos
CI/CD different than most of our other setups

What is the new behavior (if this is a feature change)?
CI/CD triggerd by user click (workflow_dispatch)
CI/CD from generic workflows
CI/CD same as our other setups

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

For now put it as a default value in the dockerfile. If we want to force users to specify the value each time, we could put it in an env file

…t of workflow

For now put it as a default value in the dockerfile. If we want to force
users to specify the value each time, we could put it in an env file

Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
Copy link
Copy Markdown
Member

@olperr1 olperr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be adapted to be more in line with the "server" repositories' new workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants