Task #38: CI workflow 최소 권한 명시와 CodeQL alert 해소#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
contents: read만 추가하고 local CI/package 및 upstream diff를 검증했습니다.변경 내역
contents: read만 추가하고 기존 동작과 publish 경계를 검증했습니다.영향 영역
GITHUB_TOKENworkflow-levelcontents: readid-token또는 추가 scope가 없는지 확인작업 문서
핵심 리뷰 포인트
.github/workflows/ci.ymldiff는permissions: contents: read3줄 추가뿐입니다.origin/mainCI와 동일합니다..github/workflows/publish.yml의 trusted publishing permission은 변경하지 않았습니다.검증
자동 검증
YAML.safe_loadexact object 비교contents: read하나, job override 없음origin/mainYAML 비교npm testnpm pack --dry-run --json, help/version smokegit diff --check수동/시나리오 검증
read, PR approval false, 외부 설정 비변경CI/원격 검증
검증 한계
fixed는 merge commit 기준 post-merge gate에서 확인합니다.관련 이슈
후속 이슈 제안
남은 리스크