fix: RemoteOperations::exec_command passes exec_env incorrectly #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we pass exec_env, we expect that they will be available within nested applications but it does not happen. The reason is in incorrect commands for setting environment variables - "name1=value1;name2=value2;<command>". We have to use "export name1=value1;export name2=value2;<command>". The new test "test_exec_command_with_exec_env__2" is added. It fails on old implementation and works fine on the new one.
dmitry-lipetsk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we pass exec_env, we expect that they will be available within nested applications but it does not happen.
The reason is in incorrect commands for setting environment variables - "name1=value1;name2=value2;".
We have to use "export name1=value1;export name2=value2;".
The new test "test_exec_command_with_exec_env__2" is added. It fails on old implementation and works fine on the new one.