fix(id): escape values assigned through the value setter#326
Open
greymoth-jp wants to merge 1 commit into
Open
fix(id): escape values assigned through the value setter#326greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
ID had no value setter, so a programmatically assigned id value was emitted verbatim instead of escaped. ClassName has escaped assigned values since 2018; mirror the same setter on ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDdoesn't overridevalue, so assigning toid.valuestores the string as-is andtoString()emits it unescaped.ClassNamehas had an escapingvaluesetter sinced4dda8c5("Escape class name values by default", 2018), butIDnever got the same one, even though class and id selectors are both identifiers and follow the same escaping rules.The result is wrong output for any id value that contains characters needing escapes:
Leading digits, spaces and
#break the same way:#1abc,#a b,#a#b.This adds the same setter
ClassNameuses (cssesc(v, { isIdentifier: true })stored intoraws.value), so id values escape on assignment:The new test mirrors the existing
ClassName#set valuetest.npm testpasses (lint, typecheck, full suite).