Fix ConnectClient crash with empty API key and OIDC auth skip#22
Draft
ian-flores wants to merge 3 commits intomainfrom
Draft
Fix ConnectClient crash with empty API key and OIDC auth skip#22ian-flores wants to merge 3 commits intomainfrom
ian-flores wants to merge 3 commits intomainfrom
Conversation
- Make Authorization header conditional on having an actual API key (fixes httpx.LocalProtocolError when VIP_CONNECT_API_KEY unset) - Skip auth prerequisite tests gracefully for OIDC without --interactive-auth instead of failing
|
Move non-password auth check before page navigation so tests skip immediately instead of timing out against Keycloak redirect URLs that don't match the sign-in/login URL patterns.
When --interactive-auth is used, the storage state from Connect login may not authenticate Workbench (separate OIDC sessions). Skip Workbench tests gracefully when storage state doesn't cover the Workbench domain instead of timing out on login selectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs discovered while running VIP against
ganso01-stagingfor the first time:VIP_CONNECT_API_KEYis set, the client sentAuthorization: Keywhich httpx rejected withLocalProtocolError: Illegal header value. Fixed by making the header conditional.--interactive-auth. Now skips with a helpful message.Test results (ganso01-staging)
The 3 former crashes (empty API key) now correctly skip or return proper HTTP errors.
Test plan