fix(pkg-r): Hide close button in $app() when non-interactive#262
Open
gadenbuie wants to merge 2 commits into
Open
fix(pkg-r): Hide close button in $app() when non-interactive#262gadenbuie wants to merge 2 commits into
gadenbuie wants to merge 2 commits into
Conversation
cpsievert
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #259
Summary
$app()renders a fixed close button that callsshiny::stopApp()when clicked. In a deployed app,stopApp()crashes the session for all users. This fix gates both the button (UI) and theobserveEvent(server) onrlang::is_interactive(), so neither exists when the app is running in a non-interactive context such as a deployed Shiny app.Verification
Run
querychat(ames)from an interactive R session — the close button appears in the top-right corner and clicking it returns the result as before. In a deployed app the button is absent.