Stabilize Python background IPC holder test#122
Draft
t-kalinowski wants to merge 2 commits into
Draft
Conversation
Finding: [P2] Ensure the IPC holder is released on early failures — /Users/tomasz/.stepper/mcp-repl/stepper-1/tests/python_backend.rs:856-857: When any path after `arm_background_ipc_holder()` exits early, for example a later `write_stdin_raw_with(...).await?` error or assertion panic, this loop has no timeout and the `TempDir` is dropped without writing `holder-release`, so the Python child keeps polling a deleted path and can be left orphaned in CI or on a developer machine. Add a cleanup guard/Drop release or avoid unguarded `?`/panics after arming so the release marker is always written. Response: BackgroundIpcHolderProbe now writes the release marker from Drop and waits with a bounded synchronous poll before its TempDir is removed, while preserving the explicit async release path for normal test cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue:
wyxvSummary
Stabilizes the Python background IPC holder teardown tests by replacing the sleep-based holder fixture with explicit ready, release, and exited synchronization.
Public-facing changes: none. This is a test-only change.
Internal-only changes:
Validation
cargo checkcargo buildpython3 tests/run_integration_tests.py --binary target/debug/mcp-replcargo clippy --all-targets --all-features -- -D warningscargo test --quietcargo +nightly fmtRisks / Rollback
Risk is limited to test behavior. If the fixture introduces a regression, revert the test-only commits on this branch.
Screenshots / Videos
Not applicable; this is a backend test-only change.