Upgrade to duckdb v1.10502 and arrow v58#447
Merged
Merged
Conversation
c0339dd to
63eb451
Compare
teunbrand
approved these changes
May 14, 2026
Collaborator
There was a problem hiding this comment.
There is an example where this code exists:
ggsql/doc/syntax/layer/type/spatial.qmd
Line 76 in ac41e62
and should probably become (I've not tested this myself)
FILTER ST_Intersects(ST_GeomFromWKB(geom), ST_MakeEnvelope(-20.0, -35.0, 55.0, 38.0))
Otherwise, this LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade duckdb-rs and arrow, to align the required arrow version in preparation for #422.
Includes changes to deal with two duckdb issues,
GEOMETRYtype duckdb/duckdb-rs#714With this PR we cannot consume
.parquetfiles withGEOMETRYcolumns without casting. For now we cast theworldbuiltin dataset to WKB when loading. This can be removed once we upgrade to a version of duckdb-rs that has fixed support forGEOMETRY.The solution in the meantime for if when user needs to use their own
.parquetfile with aGEOMETRYcolumn is to cast to WKB binary format when loading the data,