Skip to content

update to ggsql 0.4.1 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasp85 merged 1 commit into from
Jun 22, 2026
Merged

update to ggsql 0.4.1 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/MainDistributionPipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ concurrency:
jobs:
duckdb-stable-build:
name: Build extension binaries
uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@v1.5.1
uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@v1.5.4
with:
duckdb_version: v1.5.1
ci_tools_version: v1.5.1
duckdb_version: v1.5.4
ci_tools_version: v1.5.4
extension_name: ggsql
extra_toolchains: 'rust'
exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads'

code-quality-check:
name: Code Quality Check
uses: duckdb/extension-ci-tools/.github/workflows/_extension_code_quality.yml@v1.5.1
uses: duckdb/extension-ci-tools/.github/workflows/_extension_code_quality.yml@v1.5.4
with:
duckdb_version: v1.5.1
ci_tools_version: v1.5.1
duckdb_version: v1.5.4
ci_tools_version: v1.5.4
extension_name: ggsql
format_checks: 'format;tidy'
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ The inner `Connection` is created lazily and **persists for the whole `ggsql_exe

## Inlined `DuckDbDialect`

`rust/src/dialect.rs` carries a verbatim copy of ggsql's `DuckDbDialect` (currently from ggsql 0.3.2's `src/reader/duckdb.rs`). We can't enable ggsql's `duckdb` feature because it pulls in `duckdb-rs` with `bundled`, which would statically link a second DuckDB into an extension already loaded inside DuckDB (symbol clashes + binary bloat). If upstream changes the dialect, re-sync manually.
`rust/src/dialect.rs` carries a verbatim copy of ggsql's `DuckDbDialect` (currently from ggsql 0.4.1's `src/reader/duckdb.rs`, with the `pub(crate)` `wrap_with_column_aliases` helper inlined). We can't enable ggsql's `duckdb` feature because it pulls in `duckdb-rs` with `bundled`, which would statically link a second DuckDB into an extension already loaded inside DuckDB (symbol clashes + binary bloat). If upstream changes the dialect, re-sync manually.

## Conventions

Expand Down
2 changes: 1 addition & 1 deletion duckdb
Open in desktop
Submodule duckdb updated 679 files
2 changes: 1 addition & 1 deletion extension-ci-tools
Open in desktop
Submodule extension-ci-tools updated 5 files
+5 −5 .github/workflows/TestCITools.yml
+23 −6 .github/workflows/_extension_distribution.yml
+2 −1 README.md
+1 −1 docker/linux_amd64_musl/Dockerfile
+1 −1 docker/linux_arm64_musl/Dockerfile
115 changes: 39 additions & 76 deletions rust/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions rust/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ crate-type = ["staticlib"]
# ggsql: default features disabled to avoid pulling duckdb-rs (bundled = second DuckDB
# linked into our extension = binary bloat and symbol clashes). Dialect is inlined in
# dialect.rs so we don't need the `duckdb` feature.
ggsql = { version = "0.3.2", default-features = false, features = ["vegalite"] }
ggsql = { version = "0.4.1", default-features = false, features = ["vegalite"] }

# Arrow: ffi for consuming DuckDB's ArrowArrayStream. `arrow::compute::concat_batches`
# is always compiled — no feature flag needed.
arrow = { version = "56", default-features = false, features = ["ffi"] }
# is always compiled — no feature flag needed. Pinned to the same major as ggsql's
# `arrow` dep (58) so `DataFrame::from_record_batch` accepts the `RecordBatch` we build.
arrow = { version = "58", default-features = false, features = ["ffi"] }

serde_json = "1"
tiny_http = "0.12"
Expand Down
Loading
Loading