feat(scripts): sort the gallery feed by title, not slug#401
Open
amylin1249 wants to merge 2 commits into
Open
Conversation
dotNomad
reviewed
Jun 23, 2026
dotNomad
left a comment
dotNomad
left a comment
Collaborator
There was a problem hiding this comment.
Great change. I have one suggestion to move code to make it a bit easier to see
Comment on lines
+181
to
+182
| // Always emit a title-sorted feed so any release (new or updated) reorders. | ||
| this.sortExtensions(); |
Collaborator
There was a problem hiding this comment.
Instead of adding this to stringify, which just configures and calls JSON.stringify, what do you think about calling sortExtensions prior to fs.writeFileSync(extensionListFilePath, list.stringify()); like so:
// Always emit a title-sorted feed so any release (new or updated) reorders.
list.sortExtensions();
fs.writeFileSync(extensionListFilePath, list.stringify());
We have to make sortExtensions public but that is fine. I think this is a bit clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #396
The gallery feed was sorted by
name(the slug), which isn't shown to users, so card order looked random. Now it will sort bytitle.It also currently only triggers a re-sort when adding a new extension (requires manually re-sorting any time there is a title change to an existing extension), so I added that it will sort on every write in
stringify()). Now, any release (a new extension or a title change to an existing one) reorders the whole feed automatically.