Extract out Writing Tests to document nextest processes#1281
Extract out Writing Tests to document nextest processes#1281DavisVaughan wants to merge 3 commits into
Writing Tests to document nextest processes#1281Conversation
lionel-
left a comment
lionel-
left a comment
There was a problem hiding this comment.
Approving but I'd make a bit terser for reasons explained inline.
|
|
||
| Prefer simple assertion macros without custom error messages: | ||
|
|
||
| ```rust |
There was a problem hiding this comment.
I'm a bit worried about overloading our agents file with test styling instructions. So I'd prefer making this section terser. It's normal for past instructions to get increasingly ignored as the context gets longer anyway, but we pay the cost of the base agents prompt on every exchange (much less when cached but it's easy for the cache to get flushed).
If styling is super important the best way is to extract in a skill for the reviewing agent, because then the instructions will be fresh and the focus of the agent.
There was a problem hiding this comment.
This was pulled almost directly from a separate section where it was previously just a bullet point. The code block seemed easier to understand?
Can you please suggest an alternative that you are happy with?
2 participants
We don't actually say in AGENTS.md that nextest means we don't have to worry about test hygiene, so lets give this a try? Might also give us a place to document other test specific conventions