Address feedback on diagnostics and authoring - #92
Merged
Conversation
Signed-off-by: a-baran-orhan <a.baranorhan@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: a-baran-orhan <a.baranorhan@gmail.com>
a-baran-orhan
marked this pull request as ready for review
July 19, 2026 17:27
The deadlift's Lower phase rose onto the balls of the feet at the bottom of the hinge: with knees flexed 25° the shin tilted 25° forward, but keeping the sole flat needs the ankle to dorsiflex that far while its ROM caps dorsiflexion at 15°, so levelPlantedFeet clamped at the limit and left a ~3.2cm heel lift. Ease the Lower-phase knee flexion 25° → 14° so the shin only tilts as far as the ankle can absorb. A hip hinge keeps soft knees and near-vertical shins anyway, so both soles now stay flat on the floor across the whole clip (0.00cm heel lift, no grounding warnings). Raising the ankle dorsiflexion ROM was explored but reverted: the superhero-landing fixture's planted foot fights its floor reaches across the XBot and procedural proportions once the ROM widens, so a global ROM bump can't stay green in `npm run eval` without a larger landing redesign.
a-baran-orhan
force-pushed
the
codex/feedback-quick-wins
branch
from
July 19, 2026 18:27
a4bcb31 to
00ad302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
External UAT in #91 exposed four connected problems: the language contract was hard to discover, custom opening shapes were impossible without adding a phase, ground-lock/collision failures were silent, and turns/travel were difficult to read spatially.
The underlying causes were split documentation, a fixed preset-only timeline base pose, no public residual-measurement layer after solving, and a visually unscaled floor. This PR adds the smallest deterministic authoring and observability layers before changing ROM profiles or solver policy.
Impact and compatibility
pose startdeclarations now produce an explicit error instead of silently replacing an earlier declaration.Viewer.getConstraintDiagnostics()and clip diagnostics expose measured outcomes without changing authored motion or current CI gates.floorGuide: false.Validation
npm test— 35 files, 393 tests passednpm run typechecknpm run eval— 1,561/1,561 biomechanical checks across the production XBot and procedural rigs; newly surfaced known constraints remain non-gating warningsnpm run build:packagesnpm run check:packages— 5 publishable packages validatednpm run buildnpx changeset status— five fixed-group packages at minor, no accidental majorsAI assistance
Material AI assistance was used to implement, test, review, and document this change under the maintainer's direction. The resulting diff was independently reviewed within the task and validated with the checks above.