Skip to content

Support single-foot ground locking - #61

Merged
a-baran-orhan merged 2 commits into
mainfrom
codex/issue-60-single-foot-ground-lock
Jul 15, 2026
Merged

Support single-foot ground locking#61
a-baran-orhan merged 2 commits into
mainfrom
codex/issue-60-single-foot-ground-lock

Conversation

@a-baran-orhan

Copy link
Copy Markdown
Member

Summary

  • add parser-owned validation for supported ground-lock effectors
  • support per-side foot_left / foot_right locks (plus per-side hand and elbow aliases) throughout rendering and evaluation
  • update editor completions, language documentation, generated docs, and focused tests

Why

ground-lock: foot_right and ground-lock: foot_left were silently accepted by the parser but ignored by the renderer. That made single-foot pivots such as the reported standing crossover turn look like turn: was broken.

The root cause was twofold:

  1. ground-lock stored arbitrary strings without validating them against an implemented effector vocabulary.
  2. the renderer exposed only grouped ground-lock mappings and contact helpers assumed both feet or both hands.

This change makes unsupported values line-anchored parser errors and carries per-side effectors through grounding, sole leveling, mocap contact preservation, floor-hand handling, and evaluation support checks.

User impact

Authors can now plant one foot while moving the opposite leg:

step "Pivot" 0.65s ease-in-out:
  turn: 180
  ground-lock: foot_right

Typos and unsupported values no longer produce a false “parses clean, no warnings” result.

Validation

  • npm test — 19 files, 263 tests passed
  • npm run typecheck
  • npm run build
  • git diff --check

Closes #60

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
posecode Ready Ready Preview, Comment Jul 15, 2026 7:56am

@a-baran-orhan
a-baran-orhan marked this pull request as ready for review July 15, 2026 07:56
@a-baran-orhan
a-baran-orhan merged commit c9c4088 into main Jul 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support single-foot ground-lock and warn on unsupported ground-lock effectors

1 participant