Support single-foot ground locking - #61
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a-baran-orhan
marked this pull request as ready for review
July 15, 2026 07:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ground-lockeffectorsfoot_left/foot_rightlocks (plus per-side hand and elbow aliases) throughout rendering and evaluationWhy
ground-lock: foot_rightandground-lock: foot_leftwere silently accepted by the parser but ignored by the renderer. That made single-foot pivots such as the reported standing crossover turn look liketurn:was broken.The root cause was twofold:
ground-lockstored arbitrary strings without validating them against an implemented effector vocabulary.This change makes unsupported values line-anchored parser errors and carries per-side effectors through grounding, sole leveling, mocap contact preservation, floor-hand handling, and evaluation support checks.
User impact
Authors can now plant one foot while moving the opposite leg:
Typos and unsupported values no longer produce a false “parses clean, no warnings” result.
Validation
npm test— 19 files, 263 tests passednpm run typechecknpm run buildgit diff --checkCloses #60