Fix arm swing accumulation and stabilize hand grips - #45
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a-baran-orhan
marked this pull request as ready for review
July 12, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The forward-lunge left shoulder accumulated the procedural swing correction every frame, causing an uncontrolled spin. Bar movements constrained only wrist position, leaving wrist and palm orientation underdetermined and producing poor-looking pull-ups, hangs, and other hand-supported movements.
Impact
Forward lunges keep stable, natural arm swing. Pull-ups and other bar-grip movements now use a consistent contact-aware hand orientation without moving the wrist away from its IK anchor. This establishes an orientation-aware contact layer for future handles, rails, and two-handed props.
Validation
npm test -- --run— 246 tests passednpm run build— production build passed