fix(showcase): commit jumping-jacks clip so the Mixamo hero works in production - #42
Merged
Merged
Conversation
…production The Mixamo hero/playground clip never actually played in production: the .fbx files are gitignored and there is no /clips CDN rewrite in vercel.json, so /clips/jumping-jacks.fbx 404s and silently falls back to procedural. (Verified: prod /clips/jumping-jacks.fbx -> 404, while the committed /models/character.glb -> 200.) Fix mirrors how character.glb is already handled — commit the single clip the marketing surfaces use so Vercel serves it directly: - .gitignore: negate the ignore for jumping-jacks.fbx only; the other five large, unused Mixamo clips stay ignored - playground/public/clips/jumping-jacks.fbx: committed (375 KB, smaller than the already-committed 702 KB character.glb) - playground/src/clips.ts: correct the stale 'served from CDN' comment No CDN/infra required. typecheck, build, and tests all pass; the clip is emitted into playground/dist/clips/ by the build.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #41. The Mixamo jumping-jacks hero still showed procedural in production after #41 merged. Root cause: the
.fbxclips are gitignored and there is no/clipsCDN rewrite invercel.json, so the browser's request for/clips/jumping-jacks.fbx404s in production and the viewer silently falls back to procedural. The clip only ever worked locally, where the gitignored file physically exists.Evidence:
https://www.posecode.org/clips/jumping-jacks.fbx→ HTTP 404https://www.posecode.org/models/character.glb→ HTTP 200 (this model is committed, which is why the skinned figure renders).fbxis tracked in git;vercel.jsonhas no/clips/*rewrite.The "served from storage/CDN in production" comment described an intent that was never wired up.
Fix
Mirror how
character.glbis already handled — commit the one clip the marketing surfaces use so Vercel serves it directly frompublic/. No CDN/infra required..gitignore— negate the ignore forjumping-jacks.fbxonly; the other five large, unused Mixamo clips stay ignored.playground/public/clips/jumping-jacks.fbx— committed (375 KB — smaller than the already-committed 702 KBcharacter.glb).playground/src/clips.ts— correct the stale "served from CDN" comment.Reviewer notes
/clips/jumping-jacks.fbxshould return 200 and the landing hero + playground default should play the Mixamo loop (not procedural).playground/dist/clips/jumping-jacks.fbx, confirming Vercel will serve it./clips/*rewrite invercel.json+ uploading the assets there; this PR deliberately avoids that to stay self-contained.Type of Change
Checklist
npm run typecheckpasses successfullynpm run buildcompiles without errorsnpm test) and all tests passnpm run eval) — n/a (asset/config only, no fidelity-invariant logic changed)node scripts/generate-content-pages.mjs— n/a (no new movement)