Fix showcase: drop mismatched Mixamo clips (procedural squat/jumping-jacks) + L5 library sweep - #40
Merged
Merged
Conversation
…pages & GIFs - Convert all 71 legacy-easing moves to explicit L2 timing modes: ease-in→drive, ease-out→settle, ease-in-out→flow (interior phases flow; each move's final phase settles to rest before the loop). Behaviour-preserving (poses unchanged; 243 tests green). - Clip-back every move with a matching Mixamo clip (walk/squat/bicycle-crunch/jab-cross/ jumping-jacks/shuffling→grapevine). - Regenerate 72 movement pages + sitemap (embedded source now shows the new modes) and the 4 README GIFs. Untrack the placeholder clip binary (clips are gitignored / CDN-served).
The Mixamo 'Back Squat' is a BARBELL back squat (arms raised holding a bar) — retargeted onto our prop-less figure it reads as a weird standing pose, not a squat. Our procedural squat (L3 foot-flat + L4) is correct and looks better. Removed clip directives from squat and jumping-jacks so they use the improved procedural motion; re-rendered their GIFs.
…owcase Per review, the retargeted Mixamo clips aren't reliably better than the improved L2-L4 procedural (wrong-exercise semantics like the barbell back squat, retarget artifacts, missing props). Removed clip directives from all moves so the showcase (landing hero, playground default, README GIFs) runs the polished procedural on the skinned character. Clip infrastructure (clips.ts / retarget layer / gitignored FBX) is kept dormant for future use.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39, which merged before these commits landed — so main still shows the bad barbell-squat clip on the landing hero and README GIFs. This brings the fix.
The problem on main
The Mixamo "Back Squat" clip is a barbell back squat (arms raised holding a bar). Retargeted onto our prop-less figure it reads as a weird standing pose, not a squat — that's the "terrible squat GIF" and the off jumping-jack hero.
The fix
clipdirectives — the improved L2–L4 procedural motion is correct and looks better for these bodyweight moves. Verified in-browser on the skinned character: squat hits a proper deep position (hips back, chest up, flat feet); jumping-jacks is a clean symmetric arms-overhead "Out". Clip infrastructure kept dormant for future use.L3 (foot-flat, grip) and L4 (relaxed hands, arm swing, look-at) apply automatically in the frame loop.
🤖 Generated with Claude Code