common: fix gcc 14 build — include <cmath> in speculative.cpp - #6
Open
lornecodes wants to merge 1 commit into
Open
common: fix gcc 14 build — include <cmath> in speculative.cpp#6lornecodes wants to merge 1 commit into
lornecodes wants to merge 1 commit into
Conversation
std::isfinite is used in speculative.cpp (DFlash path) but <cmath> was only reaching it transitively. gcc 14 / libstdc++ no longer pull it in, so the laguna branch fails to compile: common/speculative.cpp: error: 'isfinite' is not a member of 'std' Add the explicit include. One line; no behavior change.
|
Can confirm this is required on Ubuntu Resolute gcc 15.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lagunabranch fails to compile on gcc 14 / recent libstdc++:std::isfinite(used in the DFlash speculative path) was only reaching thetranslation unit transitively through another header. gcc 14 tightened its
standard-library includes and no longer pulls
<cmath>in that way, so thebuild breaks on Debian trixie, Fedora 40+, Arch, etc.
This adds the explicit
#include <cmath>tocommon/speculative.cpp. Oneline, no behavior change — the file just declares the header it uses.
Verified by building the
lagunabranch on Debian trixie (gcc 14.2): failswithout this, builds clean with it (Laguna-S-2.1 Q4_K_M + DFlash then run).