Skip to content

Add pony-lint and fix all lint errors - #139

Closed
SeanTAllen wants to merge 1 commit into
mainfrom
add-pony-lint
Closed

Add pony-lint and fix all lint errors#139
SeanTAllen wants to merge 1 commit into
mainfrom
add-pony-lint

Conversation

@SeanTAllen

@SeanTAllen SeanTAllen commented Aug 8, 2026

Copy link
Copy Markdown
Member

Add pony-lint CI workflow and Makefile lint target, then fix all lint errors across the codebase.

Fixed error categories: acronym-casing (Json to JSON, Url to URL), dot-spacing, call-argument-format, assignment-indent, match-case-indent, control-structure-alignment, line-length, blank-lines, indentation-size, public-docstring, package-docstring, docstring-format, prefer-chaining, and exhaustive-match.

Six file-naming errors remain. These require file renames that would be a separate change:

  • paginated_list.pony -> linked_result_receiver.pony (principal type: LinkedResultReceiver)
  • request/_ssl.pony -> ssl_context_factory.pony (principal type: SSLContextFactory)
  • request/check_requester.pony -> check_result_receiver.pony (principal type: CheckResultReceiver)
  • request/json.pony -> json_converter.pony (principal type: JSONConverter)
  • request/json_requester.pony -> json_requester_result_receiver.pony (principal type: JSONRequesterResultReceiver)
  • request/no_content_requester.pony -> delete_result_receiver.pony (principal type: DeleteResultReceiver)

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Aug 8, 2026
@SeanTAllen

Copy link
Copy Markdown
Member Author

The Lint Pony source check fails because pony-lint is OOM-killed (signal 9, exit 137) — the project is too large for pony-lint to analyze within CI's memory limits. This also happens locally with Docker's default memory settings.

This is a pony-lint resource issue, not a code problem. The style fixes in this PR are correct — verified locally. The lint CI can't pass until pony-lint's memory usage is addressed.

Add pony-lint CI workflow and Makefile lint target, then fix all lint
errors across the codebase: acronym casing (Json->JSON, Url->URL),
dot-spacing, call-argument-format, assignment-indent, match-case-indent,
control-structure-alignment, line-length, blank-lines, indentation-size,
public-docstring, package-docstring, docstring-format, prefer-chaining,
and exhaustive-match annotations.

Six file-naming errors remain. These require file renames that would be
a separate change.
@SeanTAllen
SeanTAllen marked this pull request as draft August 19, 2026 18:45
@SeanTAllen SeanTAllen closed this Aug 19, 2026
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants