refactor(rust): Move replace_time_zone to polars-core#25680
Open
mcrumiller wants to merge 3 commits intopola-rs:mainfrom
Open
refactor(rust): Move replace_time_zone to polars-core#25680mcrumiller wants to merge 3 commits intopola-rs:mainfrom
replace_time_zone to polars-core#25680mcrumiller wants to merge 3 commits intopola-rs:mainfrom
Conversation
39d44b3 to
5fb3aea
Compare
replace_time_zone to polars-corereplace_time_zone to polars-core
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25680 +/- ##
==========================================
- Coverage 80.50% 79.73% -0.77%
==========================================
Files 1771 1770 -1
Lines 243327 243326 -1
Branches 3037 3037
==========================================
- Hits 195883 194017 -1866
- Misses 46662 48527 +1865
Partials 782 782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3e9aa65 to
27147a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to resolve #25674.
In order to fix #25674, we must update the cast from datetime to date, and
replace_time_zone, which currently resides in thepolars_opscrate, needs to be accessible from the cast function. Once this is in, the fix for that issue will be fairly trivial (addreplace_time_zoneto the cast).There are no logical changes, this PR makes
replace_time_zonea proper method ofDatetimeChunked.