Split gql files to one per object#197
Closed
vitaminmoo wants to merge 1 commit intopoe-tool-dev:mainfrom
Closed
Conversation
- Aiming for consistency between poe2/ and the top level files - Also aiming to enable programmatic manipulation - Automatically done by a tool, trivial to redo if stuff changes - Comments preserved - I have verified that it has no impact on the resulting schemas (see [poe-tool-dev#196](poe-tool-dev#196)) - Version comments added for all definitions currently inside files with versions in the name, so I believe no information is lost - It fixed one difference in poe2 file name vs definition name - It added some trailing carriage returns but that seems sane?
Collaborator
|
Rejecting, you can experiment manipulation on poe2 first . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#196)
I'm happy to upload the tool I used to make this if that is preferred over this mega-pr.