Added minimal permission for 'spo cdn related' commands. Closes #7265#7389
Open
nanddeepn wants to merge 1 commit into
Open
Added minimal permission for 'spo cdn related' commands. Closes #7265#7389nanddeepn wants to merge 1 commit into
nanddeepn wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a standardized Permissions section to SharePoint Online (spo) CDN command docs, documenting required delegated vs application permissions.
Changes:
- Added a new “## Permissions” section using Docusaurus Tabs/TabItem to multiple CDN command pages
- Added
@theme/Tabs/@theme/TabItemimports to some MDX pages to support the new UI
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/docs/cmd/spo/cdn/cdn-set.mdx | Adds tabbed delegated/application permissions table to the command doc |
| docs/docs/cmd/spo/cdn/cdn-policy-set.mdx | Adds tabbed delegated/application permissions table to the command doc |
| docs/docs/cmd/spo/cdn/cdn-policy-list.mdx | Adds tabbed permissions section (but imports aren’t shown/added in diff) |
| docs/docs/cmd/spo/cdn/cdn-origin-remove.mdx | Adds tabbed delegated/application permissions table to the command doc |
| docs/docs/cmd/spo/cdn/cdn-origin-list.mdx | Adds tabbed permissions section (but imports aren’t shown/added in diff) |
| docs/docs/cmd/spo/cdn/cdn-origin-add.mdx | Adds tabbed delegated/application permissions table to the command doc |
| docs/docs/cmd/spo/cdn/cdn-get.mdx | Adds tabbed permissions section (but imports aren’t shown/added in diff) |
Comment on lines
+24
to
+41
| ## Permissions | ||
|
|
||
| <Tabs> | ||
| <TabItem value="Delegated"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|----------------------| | ||
| | SharePoint | AllSites.FullControl | | ||
|
|
||
| </TabItem> | ||
| <TabItem value="Application"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|-----------------------| | ||
| | SharePoint | Sites.FullControl.All | | ||
|
|
||
| </TabItem> | ||
| </Tabs> |
Comment on lines
+24
to
+41
| ## Permissions | ||
|
|
||
| <Tabs> | ||
| <TabItem value="Delegated"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|----------------------| | ||
| | SharePoint | AllSites.FullControl | | ||
|
|
||
| </TabItem> | ||
| <TabItem value="Application"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|-----------------------| | ||
| | SharePoint | Sites.FullControl.All | | ||
|
|
||
| </TabItem> | ||
| </Tabs> |
Comment on lines
+24
to
+41
| ## Permissions | ||
|
|
||
| <Tabs> | ||
| <TabItem value="Delegated"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|----------------------| | ||
| | SharePoint | AllSites.FullControl | | ||
|
|
||
| </TabItem> | ||
| <TabItem value="Application"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|-----------------------| | ||
| | SharePoint | Sites.FullControl.All | | ||
|
|
||
| </TabItem> | ||
| </Tabs> |
Comment on lines
+32
to
+47
| <Tabs> | ||
| <TabItem value="Delegated"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|----------------------| | ||
| | SharePoint | AllSites.FullControl | | ||
|
|
||
| </TabItem> | ||
| <TabItem value="Application"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|-----------------------| | ||
| | SharePoint | Sites.FullControl.All | | ||
|
|
||
| </TabItem> | ||
| </Tabs> |
Comment on lines
+27
to
+44
| ## Permissions | ||
|
|
||
| <Tabs> | ||
| <TabItem value="Delegated"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|----------------------| | ||
| | SharePoint | AllSites.FullControl | | ||
|
|
||
| </TabItem> | ||
| <TabItem value="Application"> | ||
|
|
||
| | Resource | Permissions | | ||
| |------------|-----------------------| | ||
| | SharePoint | Sites.FullControl.All | | ||
|
|
||
| </TabItem> | ||
| </Tabs> |
Contributor
|
Thanks! We'll review it soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added minimal permission for
spo cdn relatedcommands. Closes #7265