Improve test-function

[bouwew]

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for thermostat validation by adding log assertion checks.

[coderabbitai]

📝 Walkthrough

Walkthrough

Test method in tests/test_adam.py renamed from test_connect_adam_jvonk to test_connect_adam_bad_thermostat, adds log capture parameter, removes skip_testing=True argument, and includes assertion validating "Thermostat data in Zone" log message.

Changes

Cohort / File(s)	Summary
Test Method Update tests/test_adam.py	Renamed test method, added caplog fixture for log verification, and introduced assertion to validate thermostat-related log message output.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Improve handling of missing thermostat data #861: Adds guards and logging for missing thermostat data that this test now explicitly verifies through the "Thermostat data in Zone" log assertion.

Suggested reviewers

• CoMPaTech

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Improve test-function' is vague and generic, using non-descriptive language that doesn't convey what specific improvement was made to which test.	Replace with a more specific title that describes the actual change, such as 'Rename test_connect_adam_jvonk to test_connect_adam_bad_thermostat and add log assertion' or 'Update test_connect_adam to verify thermostat error logging'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch delayed-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c12d6fa) to head (fb63431).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #862   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3456      3457    +1     
=========================================
+ Hits          3456      3457    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.