Skip to content

Handle missing thermostat data #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bouwew wants to merge 13 commits into from
Closed

Handle missing thermostat data #860

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9e32a0f
Add JVonk userdata
bouwew Mar 5, 2026
4be6c97
Test the added userdata
bouwew Mar 5, 2026
c630812
Debug
bouwew Mar 6, 2026
d8ae204
Guard for missing thermostat data
bouwew Mar 6, 2026
367391b
Move debug-logger
bouwew Mar 6, 2026
cf9e669
Update logger-message, remove test-debug-logger
bouwew Mar 6, 2026
d3fae83
Correct return
bouwew Mar 6, 2026
ac88dc4
Save reformatted files
bouwew Mar 6, 2026
06ae5fc
Rename folders
bouwew Mar 6, 2026
0dc5689
Save added fixture
bouwew Mar 6, 2026
d0caf24
Copy testdata from fixture
bouwew Mar 6, 2026
1dec4d3
Update CHANGELOG
bouwew Mar 6, 2026
718b3e0
Use get() to avoid potential error-case, improve message
bouwew Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
532 changes: 532 additions & 0 deletions fixtures/adam_bad_thermostat/data.json
View file
Open in desktop

Large diffs are not rendered by default.

186 changes: 155 additions & 31 deletions fixtures/adam_heatpump_cooling/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Slaapkamer SJ",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "off",
"select_zone_profile": "passive",
"sensors": {
Expand All @@ -27,11 +33,17 @@
"upper_bound": 99.9
},
"thermostats": {
"primary": ["d3a276aeb3114a509bab1e4bf8c40348"],
"primary": [
"d3a276aeb3114a509bab1e4bf8c40348"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
},
"0ca13e8176204ca7bf6f09de59f81c83": {
"available": true,
Expand Down Expand Up @@ -132,7 +144,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Slaapkamer DB",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "off",
"select_zone_profile": "passive",
"sensors": {
Expand All @@ -147,11 +165,17 @@
"upper_bound": 99.9
},
"thermostats": {
"primary": ["47e2c550a33846b680725aa3fb229473"],
"primary": [
"47e2c550a33846b680725aa3fb229473"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
},
"2e0fc4db2a6d4cbeb7cf786143543961": {
"available": true,
Expand Down Expand Up @@ -248,7 +272,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Badkamer 2",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "Werkdag schema",
"select_zone_profile": "passive",
"sensors": {
Expand All @@ -262,11 +292,17 @@
"upper_bound": 99.9
},
"thermostats": {
"primary": ["f04c985c11ad4848b8fcd710343f9dcf"],
"primary": [
"f04c985c11ad4848b8fcd710343f9dcf"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
},
"5ead63c65e5f44e7870ba2bd680ceb9e": {
"available": true,
Expand Down Expand Up @@ -294,7 +330,11 @@
},
"dev_class": "gateway",
"firmware": "3.2.8",
"gateway_modes": ["away", "full", "vacation"],
"gateway_modes": [
"away",
"full",
"vacation"
],
"hardware": "AME Smile 2.0 board",
"location": "eedadcb297564f1483faa509179aebed",
"mac_address": "012345670001",
Expand Down Expand Up @@ -392,7 +432,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Badkamer 1",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "Werkdag schema",
"select_zone_profile": "passive",
"sensors": {
Expand All @@ -407,11 +453,17 @@
"upper_bound": 99.9
},
"thermostats": {
"primary": ["eac5db95d97241f6b17790897847ccf5"],
"primary": [
"eac5db95d97241f6b17790897847ccf5"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
},
"93ac3f7bf25342f58cbb77c4a99ac0b3": {
"active_preset": "away",
Expand All @@ -426,7 +478,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Slaapkamer RB",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "off",
"select_zone_profile": "passive",
"sensors": {
Expand All @@ -440,11 +498,17 @@
"upper_bound": 99.9
},
"thermostats": {
"primary": ["c4ed311d54e341f58b4cdd201d1fde7e"],
"primary": [
"c4ed311d54e341f58b4cdd201d1fde7e"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
},
"96714ad90fc948bcbcb5021c4b9f5ae9": {
"available": true,
Expand Down Expand Up @@ -479,7 +543,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Slaapkamer SQ",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "off",
"select_zone_profile": "passive",
"sensors": {
Expand All @@ -494,11 +564,17 @@
"upper_bound": 99.9
},
"thermostats": {
"primary": ["beb32da072274e698146db8b022f3c36"],
"primary": [
"beb32da072274e698146db8b022f3c36"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
},
"a03b6e8e76dd4646af1a77c31dd9370c": {
"available": true,
Expand Down Expand Up @@ -533,7 +609,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Keuken",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "Werkdag schema",
"select_zone_profile": "active",
"sensors": {
Expand All @@ -548,11 +630,17 @@
"upper_bound": 99.9
},
"thermostats": {
"primary": ["ea8372c0e3ad4622ad45a041d02425f5"],
"primary": [
"ea8372c0e3ad4622ad45a041d02425f5"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
},
"b52908550469425b812c87f766fe5303": {
"active_preset": "away",
Expand All @@ -567,7 +655,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Bijkeuken",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "off",
"select_zone_profile": "active",
"sensors": {
Expand All @@ -582,11 +676,17 @@
"upper_bound": 99.9
},
"thermostats": {
"primary": ["1053c8bbf8be43c6921742b146a625f1"],
"primary": [
"1053c8bbf8be43c6921742b146a625f1"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
},
"bbcffa48019f4b09b8368bbaf9559e68": {
"available": true,
Expand Down Expand Up @@ -699,7 +799,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Slaapkamer JM",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "off",
"select_zone_profile": "passive",
"sensors": {
Expand All @@ -714,11 +820,17 @@
"upper_bound": 99.9
},
"thermostats": {
"primary": ["7fda9f84f01342f8afe9ebbbbff30c0f"],
"primary": [
"7fda9f84f01342f8afe9ebbbbff30c0f"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
},
"ea8372c0e3ad4622ad45a041d02425f5": {
"available": true,
Expand Down Expand Up @@ -803,7 +915,13 @@
"dev_class": "climate",
"model": "ThermoZone",
"name": "Woonkamer",
"preset_modes": ["no_frost", "vacation", "away", "home", "asleep"],
"preset_modes": [
"no_frost",
"vacation",
"away",
"home",
"asleep"
],
"select_schedule": "Werkdag schema",
"select_zone_profile": "active",
"sensors": {
Expand All @@ -818,10 +936,16 @@
"upper_bound": 35.0
},
"thermostats": {
"primary": ["ca79d23ae0094120b877558734cff85c"],
"primary": [
"ca79d23ae0094120b877558734cff85c"
],
"secondary": []
},
"vendor": "Plugwise",
"zone_profiles": ["active", "off", "passive"]
"zone_profiles": [
"active",
"off",
"passive"
]
}
}
Loading